Add support for reset button
#134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #117, this adds support for resetting the state of the form using a native reset button. Yielding a `reset` action will come in a separate PR.
🦋 Changeset detectedLatest commit: aeaeca5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Preview URLsEnv: preview |
ynotdraw
approved these changes
May 15, 2023
test-app/tests/integration/components/headless-form-reset-test.gts
Outdated
Show resolved
Hide resolved
| .doesNotExist('validation errors are removed on reset'); | ||
| assert.dom('[data-test-first-name]').doesNotHaveAria('invalid'); | ||
| assert.dom('[data-test-invalid]').doesNotExist(); | ||
| }); |
Co-authored-by: Tony Ward <[email protected]>
Merged
nicolechung
reviewed
May 16, 2023
| delete this.internalData[key as keyof DATA]; | ||
| } | ||
|
|
||
| this.validationState = undefined; |
There was a problem hiding this comment.
Late to this, but: are we going to have explicit states for pristine/dirty or the consumer can figure this out from the validationState and the submissionState?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #117, closes #122, this adds support for resetting the state of the form using a native reset button. Yielding a
resetaction will come in a separate PR.Merge #132 first!