Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ BUG ] Boolean query string parameters are not being converted to lower case strings #1129

Closed
jshcodes opened this issue Mar 7, 2024 · 0 comments · Fixed by #1134
Closed

[ BUG ] Boolean query string parameters are not being converted to lower case strings #1129

jshcodes opened this issue Mar 7, 2024 · 0 comments · Fixed by #1134
Assignees
@jshcodes
Labels
bug 🐛 Something isn't working kubernetes Kubernetes Protection issues and questions SDK usage General SDK usage issues and questions

Comments

@jshcodes
Copy link
Member

jshcodes commented Mar 7, 2024 •
edited
Loading

Describe the bug
Boolean query string parameters sent thru the requests library are being passed to the API using title case. This will generate an error in some API operations as they are expecting a lower case string.

To Reproduce
Call the GetHelmValuesYaml operation while passing a True for the is_self_managed_cluster argument.

Expected behavior
The generated query string properly converts booleans into lower case strings.

Environment (please complete the following information):

  • OS: All supported
  • Python: All supported
  • FalconPy: 1.3.0+

Additional context
Thanks @falcon-pioupiou for identifying and reporting this issue!
@jshcodes jshcodes added bug 🐛 Something isn't working kubernetes Kubernetes Protection issues and questions labels Mar 7, 2024
@jshcodes jshcodes self-assigned this Mar 7, 2024
@jshcodes jshcodes added the SDK usage General SDK usage issues and questions label Mar 7, 2024
@jshcodes jshcodes changed the title [ BUG ] Boolean query string parameters are no longer being converted to lower case strings [ BUG ] Boolean query string parameters are not being converted to lower case strings Mar 7, 2024
jshcodes added a commit that referenced this issue Mar 7, 2024
@jshcodes
Fix query string boolean conversions. Closes #1129.
b895478
jshcodes added a commit that referenced this issue Mar 20, 2024
@jshcodes
Fix query string boolean conversions. Closes #1129.
8cd12d4
jshcodes added a commit that referenced this issue Mar 20, 2024
@jshcodes
Fix query string boolean conversions. Closes #1129.
bc2e3e2
@jshcodes jshcodes mentioned this issue Mar 20, 2024
Merged
4 tasks
jshcodes added a commit that referenced this issue Mar 22, 2024
@jshcodes
Fix query string boolean conversions. Closes #1129.
4bdea73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
bug 🐛 Something isn't working kubernetes Kubernetes Protection issues and questions SDK usage General SDK usage issues and questions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 1.4.2 - New operations and updates, expanded Environment Authentication CrowdStrike/falconpy
1 participant
@jshcodes