Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ BUG ] ID list parsing issue with MSSP.getChildren #144

Closed
jshcodes opened this issue Apr 27, 2021 · 0 comments · Fixed by #146
Closed

[ BUG ] ID list parsing issue with MSSP.getChildren #144

jshcodes opened this issue Apr 27, 2021 · 0 comments · Fixed by #146
Assignees
@jshcodes
Labels
bug 🐛 Something isn't working Flight Control Flight Control (MSSP) issues and questions
Milestone
Parameter diction...

Comments

@jshcodes
Copy link
Member

Description

When calling getChildren, and providing a properly formatted list or comma-delimited string for the ids argument, a 500 error is generated.

This is confirmed to not be generated via the API, and is coming from the Service Class call to requests.

This issue does not impact the Uber class.

See discussion post #143 for more detail.

To Reproduce

Create an instance of the MSSP service class, and then call getChildren passing either a list or a comma-delimited string for the ids argument.

Expected Behavior

Properly formatted API results matching what is produced when performing this operation via the Uber class.

Environment

  • OS: MacOS 10.15.7 (Assume all operating systems, all versions)
  • Python: 3.9+ (Assume 3.6+)
  • FalconPy: 0.4.6+
@jshcodes jshcodes added the bug 🐛 Something isn't working label Apr 27, 2021
@jshcodes jshcodes self-assigned this Apr 27, 2021
@jshcodes jshcodes pinned this issue Apr 28, 2021
@jshcodes jshcodes unpinned this issue Apr 28, 2021
jshcodes added a commit that referenced this issue Apr 28, 2021
@jshcodes
Refactored to new Service Class pattern. Closes #144
8b8fbe6
@jshcodes jshcodes mentioned this issue Apr 29, 2021
Merged
2 tasks
jshcodes added a commit that referenced this issue Apr 29, 2021
@jshcodes
[DEPLOY] Refactored MSSP Service Class (#146)
40e34ff 
* Updating version number to 0.4.8

* Refactored to new Service Class pattern. Closes #144

* Fix linting

* Update CHANGELOG.md

Co-authored-by: Shane Shellenbarger <[email protected]>
@jshcodes jshcodes added the Flight Control Flight Control (MSSP) issues and questions label Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
bug 🐛 Something isn't working Flight Control Flight Control (MSSP) issues and questions
Projects
None yet
Milestone
Parameter dictionary fully abstracted
Development

Successfully merging a pull request may close this issue.

[DEPLOY] Refactored MSSP Service Class CrowdStrike/falconpy
1 participant
@jshcodes