Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUG ] You cannot call the oauth2AccessToken and oauth2RevokeToken operations directly from the Uber Class command method #835

Closed
jshcodes opened this issue Nov 23, 2022 · 0 comments · Fixed by #1015
Assignees
Labels
authentication Issues or questions regarding authentication bug 🐛 Something isn't working uber Questions related to Uber Class usage

Comments

@jshcodes
Copy link
Member

Describe the bug
Due to how the Uber Class implements authentication, and the custom payloads required to authenticate to the API, the Uber Class cannot leverage the two OAuth2 service collection operations, oauth2AccessToken and oauth2RevokeToken.

To Reproduce
Create an authenticated instance of the Uber Class. Attempt to call the revoke operation using the following command.

from falconpy import APIHarness

uber = APIHarness(client_id=CLIENT_ID, client_secret=CLIENT_SECRET)

result = uber.command("oauth2RevokeToken")

Expected behavior
Developers should be able to leverage methods from this service collection from the Uber Class just like they can from the Service Class.

Environment (please complete the following information):

  • OS: All Supported
  • Python: All Supported
  • FalconPy: <=1.2.x

Additional context
Discovered while refactoring to implement enhancements to the authentication and Service Class objects. (Related to #829)

This issue has been resolved in the upcoming v1.3.0 version.

@jshcodes jshcodes added the bug 🐛 Something isn't working label Nov 23, 2022
@jshcodes jshcodes self-assigned this Nov 23, 2022
@jshcodes jshcodes added authentication Issues or questions regarding authentication uber Questions related to Uber Class usage labels Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Issues or questions regarding authentication bug 🐛 Something isn't working uber Questions related to Uber Class usage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant