Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about weighting and codebook #226

Closed
1beb opened this issue Dec 15, 2020 · 0 comments · Fixed by #231
Closed

Add note about weighting and codebook #226

1beb opened this issue Dec 15, 2020 · 0 comments · Fixed by #231

Comments

@1beb
Copy link
Collaborator

1beb commented Dec 15, 2020

Codebooks are designed to work with whole numbers. A weighted dataset present a count as a decimal and this breaks the presentation of the codebook significantly.

We should warn users of this behavior, and denote the fix in examples:

weight(ds) <- NULL

Datasets must be unweighted and this needs to be made clear for the user. Consider adding an in-code warning or stop(). We can't "do it for them" because we don't want to edit the state of a dataset on behafl of a user (let's say they are generating a codebook for a client but the client is also looking at these data in crunch).

@1beb 1beb closed this as completed Jan 4, 2021
@1beb 1beb mentioned this issue Jan 4, 2021
1beb added a commit that referenced this issue Jan 5, 2021
Adding a stop to writeCodeBookLatex for #226
@1beb 1beb mentioned this issue Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant