Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update derived categories via expression #476

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

gergness
Copy link
Contributor

@gergness gergness commented Aug 4, 2020

exploring what it would look like to use expressions to update categories for derived variables instead of the endpoint.

Would need more zcl hacking than I'd like until https://www.pivotaltracker.com/story/show/174173987, so am pausing work for now.

@lintr-bot
Copy link

R/categories.R:272:1: style: Lines should not be more than 100 characters.

!isTRUE(all.equal(old[[attr]], new[[attr]])) && !(is.na(old[[attr]]) && is.null(new[[attr]])) && !(is.null(old[[attr]]) && is.na(new[[attr]]))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

R/categories.R:278:1: style: Lines should not be more than 100 characters.

# We'll use `selectCategories()` for selection changes, but `alterCategories()` for everything else
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

R/expressions.R:617:1: style: Lines should not be more than 100 characters.

if (!is.null(category_order)) args$order <- list(value = alter_cats_get_order_ids(x, category_order))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@gergness gergness marked this pull request as draft August 6, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants