Restore man pages #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MattF-NSIDC
commented
May 19, 2023
| @@ -44,6 +44,8 @@ jobs: | |||
| IMAGE_NAME: "cryointhecloud/cryo-hub-image" | |||
| # Put repo contents in /srv/repo, so they aren't mangled when we put user home in /home/jovyan | |||
| REPO_DIR: /srv/repo | |||
| # Fix man pages that are disabled by Ubuntu 18 minimal base image | |||
There was a problem hiding this comment.
Suggested change
| # Fix man pages that are disabled by Ubuntu 18 minimal base image |
This comment is probably redundant. Commit this suggestion if you agree :)
tsnow03
approved these changes
May 22, 2023
|
Just saw the message about image size, @MattF-NSIDC. I think additional 3GB could add 30s, maybe a minute to image pull performance. Unless man pages are being explicitly taught in the workshop, I would recommend against using |
|
We have been planning to teach man pages in the workshop. Does the image need to be pulled for every new node-share or only when a new node is being provisioned? Do you know of a less inflationary approach than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The appendix file method was the only way I could find to successfully
unminimizethe minimal image and bring back man pages.EDIT: This brings total image size to 11.3 GB from 8.16GB.
unminimizeis probably bringing back more thanmanpages. Maybe there is a way we can restoremanpages without using the fullunminimizescript?Resolves #63