Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Log Output #87

Merged
merged 17 commits into from
Dec 26, 2023
Merged

Improve Log Output #87

merged 17 commits into from
Dec 26, 2023

Conversation

RadWolfie
Copy link
Member

The changes are absolutely necessary in order to include line number of where the fault occur at. Plus remove individual test's passing verbose to only when comparison failure occur. Doing so will require update each tests that are affected.

The only remaining print(...) calls are:

  • debug message:
    • AvSendTVEncoderOption (currently disabled)
    • AvSetDisplayMode (currently disabled)
    • ExAcquireReadWriteLockExclusive (require resolve in separate pull request)
    • ExAcquireReadWriteLockShared (require resolve in separate pull request)
  • error message for unable allocate memory:
    • RtlMoveMemory
    • RtlZeroMemory
    • RtlAnsiStringToUnicodeString

Partial fix by #6 which include build hash at this time.

Note

A few tests has been changed to use direct comparison such as:

  • RtlCompareString
  • RtlCompareUnicodeString

Do expect failures for above tests, although I did made an update to cxbxr's kernel implements to properly return expected value.

@ergo720 ergo720 merged commit bf56317 into Cxbx-Reloaded:master Dec 26, 2023
1 check passed
@RadWolfie RadWolfie deleted the improve-log branch December 26, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants