Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the way sample codes read configuration #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 29 additions & 32 deletions src/Configuration.cs
Original file line number Diff line number Diff line change
@@ -1,32 +1,29 @@
using System.Collections.Generic;

namespace Cybersource_rest_samples_dotnet
{
public class Configuration
{
// initialize dictionary object
private readonly Dictionary<string, string> _configurationDictionary = new Dictionary<string, string>();

public Dictionary<string, string> GetConfiguration()
{
_configurationDictionary.Add("authenticationType", "HTTP_SIGNATURE");
_configurationDictionary.Add("merchantID", "testrest");
_configurationDictionary.Add("merchantsecretKey", "yBJxy6LjM2TmcPGu+GaJrHtkke25fPpUX+UY6/L/1tE=");
_configurationDictionary.Add("merchantKeyId", "08c94330-f618-42a3-b09d-e1e43be5efda");
_configurationDictionary.Add("keysDirectory", "Resource");
_configurationDictionary.Add("keyFilename", "testrest");
_configurationDictionary.Add("runEnvironment", "cybersource.environment.sandbox");
_configurationDictionary.Add("keyAlias", "testrest");
_configurationDictionary.Add("keyPass", "testrest");
_configurationDictionary.Add("enableLog", "FALSE");
_configurationDictionary.Add("logDirectory", string.Empty);
_configurationDictionary.Add("logFileName", string.Empty);
_configurationDictionary.Add("logFileMaxSize", "5242880");
_configurationDictionary.Add("timeout", "300000");
_configurationDictionary.Add("proxyAddress", string.Empty);
_configurationDictionary.Add("proxyPort", string.Empty);

return _configurationDictionary;
}
}
}
using System.Collections.Generic;
using System.IO;

namespace Cybersource_rest_samples_dotnet
{
public class Configuration
{
// initialize dictionary object
private readonly Dictionary<string, string> _configurationDictionary = new Dictionary<string, string>();

public Dictionary<string, string> GetConfiguration()
{
_configurationDictionary.Add("logDirectory", string.Empty);
_configurationDictionary.Add("logFileName", string.Empty);
_configurationDictionary.Add("proxyAddress", string.Empty);
_configurationDictionary.Add("proxyPort", string.Empty);

string[] input = File.ReadAllLines("Configuration.txt");
string[] keyValueArray;
foreach (string i in input)
{
keyValueArray = i.Split(',');
_configurationDictionary.Add(keyValueArray[0], keyValueArray[1]);
}

return _configurationDictionary;
}
}
}
12 changes: 12 additions & 0 deletions src/Configuration.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
authenticationType,JWT
merchantID,testrest
merchantsecretKey,yBJxy6LjM2TmcPGu+GaJrHtkke25fPpUX+UY6/L/1tE=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we somehow tag the different set of configuration required for different set of auth mechanism.
like, for JWT you require keyFilename which is not required if someone is using httpSignature.

merchantKeyId,08c94330-f618-42a3-b09d-e1e43be5efda
keysDirectory,Resource
keyFilename,testrest
runEnvironment,cybersource.environment.sandbox
keyAlias,testrest
keyPass,testrest
enableLog,FALSE
logFileMaxSize,5242880
timeout,300000
42 changes: 0 additions & 42 deletions src/Resource/DownloadReport.csv

This file was deleted.