Upgrade to pyiceberg #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Dec 26, 2022
metadata-ingestion/src/datahub/ingestion/source/iceberg/iceberg.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/iceberg/iceberg.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/iceberg/iceberg_common.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/iceberg/iceberg_common.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/iceberg/iceberg_profiler.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/iceberg/iceberg_profiler.py
Outdated
Show resolved
Hide resolved
|
@cccs-tom @cccs-Dustin Here are the remaining things to check FYI:
Once we migrate our platform to REST catalog, we will be able to remove the code that mimics the HadoopCatalog. |
|
lgtm! (didn't mean to approve the previous message, I will wait until the items on your checklist are completed before giving approval) |
|
iceberg_common.py:
|
cccs-eric
force-pushed
the
feature/CLDN-1784
branch
from
06f8205
to
b0b069f
Compare
cccs-tom
approved these changes
Feb 6, 2023
cccs-Dustin
approved these changes
Feb 15, 2023
cccs-eric
added a commit
that referenced
this pull request
Jul 3, 2023
* CLDN-1784 - Migration to new pyiceberg SDK * Python: update test case * Change to fsspec instead of Azure filesystem * Change how to find column count * Use Iceberg visitor to build avro schema * CLDN-1784 - Refactor code to pyiceberg * Merge setup.py * Fix linting errors * Update code comments * Added table format-version property to output * Fix dataset_name parsing problem * Use official pyiceberg release 0.3.0 * Change how we handle missing fields from schema during profiling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a WIP, looking for code review.