temporarily completely removing caching feature on SELECT

jupyterlab_sql_editor/ipython_magic/sparksql/sparksql.py

@@ -11,7 +11,6 @@
     pass
 
 import pandas as pd
-import sqlparse
 from IPython import get_ipython
 from IPython.core.magic import (
     line_cell_magic,
@@ -127,7 +126,6 @@ def __init__(self, shell=None, **kwargs):
         action="store_true",
         help="Detailed information about SparkSQL magic",
     )
-    @argument("--nocache", action="store_true", help="Do not use cache for SELECT statements")
     @argument("--jsonnulls", action="store_true", help="Show nulls for JSON output")
     def sparksql(self, line=None, cell=None, local_ns=None):
         "Magic that works both as %sparksql and as %%sparksql"
@@ -211,18 +209,20 @@ def sparksql(self, line=None, cell=None, local_ns=None):
             elif output == "sql":
                 return self.display_sql(sql)
 
-            sql_statement = sqlparse.format(sql, strip_comments=True)
-            parsed = sqlparse.parse(sql_statement.strip(" \t\n;"))
+            # TODO: Rework caching feature
+            # sql_statement = sqlparse.format(sql, strip_comments=True)
+            # parsed = sqlparse.parse(sql_statement.strip(" \t\n;"))
 
             # Use previously cached results if sql statement hasn't changed and is a SELECT type statement
-            use_cache = (
-                True
-                if not args.nocache
-                and sql == self.cached_sql
-                and limit == self.cached_limit
-                and parsed[0].get_type() == "SELECT"
-                else False
-            )
+            # use_cache = (
+            #     True
+            #     if not args.nocache
+            #     and sql == self.cached_sql
+            #     and limit == self.cached_limit
+            #     and parsed[0].get_type() == "SELECT"
+            #     else False
+            # )
+            use_cache = False
             if use_cache:
                 print("Using cached results")
 

jupyterlab_sql_editor/ipython_magic/trino/trino.py

@@ -109,7 +109,6 @@ def __init__(self, shell=None, **kwargs):
         action="store_true",
         help="Detailed information about Trino magic",
     )
-    @argument("--nocache", action="store_true", help="Do not use cache for SELECT statements")
     @argument("--jsonnulls", action="store_true", help="Show nulls for JSON output")
     def trino(self, line=None, cell=None, local_ns=None):
         "Magic that works both as %trino and as %%trino"
@@ -197,8 +196,10 @@ def trino(self, line=None, cell=None, local_ns=None):
         if not args.raw and not sql_lim and parsed[0].get_type() == "SELECT":
             sql = f"{sql} \nLIMIT {limit+1}"
 
+        # TODO: Rework caching feature
         # Use previously cached results if sql statement hasn't changed and is a SELECT type statement
-        use_cache = True if not args.nocache and sql == self.cached_sql and parsed[0].get_type() == "SELECT" else False
+        # use_cache = True if not args.nocache and sql == self.cached_sql and parsed[0].get_type() == "SELECT" else False
+        use_cache = False
         if use_cache:
             print("Using cached results")
 

package.json

@@ -1,6 +1,6 @@
 {
     "name": "jupyterlab-sql-editor",
-    "version": "1.1.3",
+    "version": "1.2.0",
     "description": "SQL editor support for formatting, syntax highlighting and code completion of SQL in cell magic, line magic, python string and file editor.",
     "keywords": [
         "jupyter",