Lint fixes #1363
Merged
Lint fixes #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
prabhu
commented
Sep 8, 2024
| @@ -55,6 +55,7 @@ import { | |||
| executeParallelGradleProperties, | |||
| extractJarArchive, | |||
| frameworksList, | |||
| generatePixiLockFile, | |||
There was a problem hiding this comment.
We should have repo tests for pixi with type python which would have caught this
prabhu
commented
Sep 8, 2024
| @@ -9882,7 +9882,6 @@ export async function getJarClasses(jarFile) { | |||
| "is not recognized as an internal or external command", | |||
| ) | |||
| ) { | |||
| jarCommandAvailable = false; | |||
There was a problem hiding this comment.
Another bug that went unreported
Signed-off-by: Prabhu Subramanian <[email protected]>
|
Denotests are consistently failing on Windows at the rm -rf command. This needs to be investigated, since the most likely cause must be atom hanging on Windows at a prior test thus blocking the rm command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more rules such as
noUndeclaredVariablesand found few bugs. Please consider using this biome.json in the new refactor branch and feel free to add more useful rules.