[Gradle] Resolve gradle module from npm package #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roland Asmann <[email protected]>
Signed-off-by: Roland Asmann <[email protected]>
|
Interesting idea! Could you kindly add some repo tests? |
|
I knew I forgot something! 😜 I'll add some, just not sure if they'll work in the build -- the previous ones still don 't work, I think... 😞 |
- Removed CDXGEN_DEBUG - Removed non-existing modules from skip Signed-off-by: Roland Asmann <[email protected]>
|
@aryan-rajoria manually tested the last PR. Even if the test doesn't work in the CI we can use the repos in our manual tests |
Signed-off-by: Roland Asmann <[email protected]>
|
Darn, I just figured out why the tests don't work -- I made a typo and obviously copied that in all 3 calls! 😭 Should be fixed now. |
|
Thank you so much for a great contribution! Please keep going! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Expo, several of the gradle modules are actually references to code in npm packages. Unfortunately the purls that are generated from this, are not known by vuln-sources like OSS Index.
This PR can resolve the module to the actual npm package so you get correct data on your components regarding vulns and licenses.