Fix: #1370 - restrict bazel projects to pattern BUILD{,.bazel}
#1373
Conversation
heubeck
force-pushed
the
fix/issue-1370
branch
from
4258360
to
f0e139e
Compare
…el}` Signed-off-by: Florian Heubeck <[email protected]>
heubeck
force-pushed
the
fix/issue-1370
branch
from
f0e139e
to
e5982ea
Compare
| @@ -1898,7 +1898,7 @@ export async function createJavaBom(path, options) { | |||
| // NOTE: This can match BUILD files used by perl, so could lead to errors in some projects | |||
| const bazelFiles = getAllFiles( | |||
| path, | |||
| `${options.multiProject ? "**/" : ""}BUILD*`, | |||
| `${options.multiProject ? "**/" : ""}BUILD{,.bazel}`, | |||
There was a problem hiding this comment.
Instead of looking for BUILD and BUILD.bazel files, it should instead:
WORKSPACE- since that defines a Bazel project (and alsoWORKSPACE.bazel), and only at the root directory of the projectMODULE.bazel- as an alternative toWORKSPACEin newer versions of Bazel
As the error suggests we can only run Bazel build commands from "below a directory having a WORKSPACE file" so even just looking for BUILD and BUILD.bazel will still result in failures.
There was a problem hiding this comment.
so
`(WORKSPACE{,.bazel}|${options.multiProject ? "**/" : ""}BUILD{,.bazel})`
would be the pattern?
or can't it be covered with the pattern at all as it's a conditional thing, depending on a WORKSPACE file to be present or not?
There was a problem hiding this comment.
I have some bazel projects without any workspace files. Not sure since when workspace was introduced
There was a problem hiding this comment.
It needs to find a WORKSPACE or a MODULE.bazel file at the root of the project, so something like
(WORKSPACE{,.bazel}|MODULE.bazel)
Alternatively you can run bazel info and look for the message
ERROR: The 'info' command is only supported from within a workspace (below a directory having a WORKSPACE file).
There was a problem hiding this comment.
Let me try this in a new PR
No description provided.