-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recover dependency tree from nuspec files #1374
Conversation
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
In addition, for non-versioned system packages (from Global Assembly Cache), target_framework property is set based on the information from the csproj file.
In the above example, there is no version information for |
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
While testing this repo, noticed that cdxgen can generate duplicates in the below scenario: <Reference Include="Microsoft.AI.Agent.Intercept, Version=2.0.6.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.ApplicationInsights.Agent.Intercept.2.0.6\lib\net45\Microsoft.AI.Agent.Intercept.dll</HintPath>
<Private>True</Private>
</Reference> The include name used is different to the package path (and it's name in the .nupkg file). Therefore, both of these components are the same. I have enhanced slightly to track the hint_path alone as a property. May be a future release could do a better job in expressing such aliases better. |
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
.nuspec files could have dependencies defined under various groups. These dependencies were getting omitted thus reducing the number of indirect components reported for .Net framework <= 4.7 applications.
The captured indirect components would have slightly lower confidence with an
optional
scope to help downstream tools to better prioritize the issues in such components. Additionally, a property calledcdx:dotnet:target_framework
can be used to identify the target frameworks these components are part of.Example: