Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Include components from pnpm-lock.yaml importers #1377

Merged
merged 11 commits into from
Sep 22, 2024
Merged

Conversation

aryan-rajoria
Copy link
Collaborator

Based on discussion in #1359, We now add dependencies for additional components found in importers section of pnpm-lock.yaml.

utils.js Outdated Show resolved Hide resolved
utils.js Outdated Show resolved Hide resolved
@aryan-rajoria aryan-rajoria marked this pull request as ready for review September 17, 2024 14:18
utils.js Fixed Show fixed Hide fixed
@prabhu prabhu marked this pull request as draft September 18, 2024 06:43
@aryan-rajoria
Copy link
Collaborator Author

prismsbom.json
rushsbom.json
sample output for rush-example repo:

    "dependencies": [
        {
            "ref": "pkg:npm/rush",
            "dependsOn": []
        },
        {
            "ref": "pkg:npm/rush/my-app#apps/my-app",
            "dependsOn": [
                "pkg:npm/my-controls",
                "pkg:npm/whatwg-fetch"
            ]
        },
        {
            "ref": "pkg:npm/rush/my-controls#libraries/my-controls",
            "dependsOn": []
        },
        {
            "ref": "pkg:npm/rush/my-toolchain#tools/my-toolchain",
            "dependsOn": [
                "pkg:npm/colors"
            ]
        },
        {
            "ref": "pkg:npm/@types/[email protected]",
            "dependsOn": []
        },.......

sample output for prism-react-renderer:

    "dependencies": [
        {
            "ref": "pkg:npm/prism-react-renderer",
            "dependsOn": []
        },
        {
            "ref": "pkg:npm/prism-react-renderer-monorepo/demo#packages/demo",
            "dependsOn": [
                "pkg:npm/clsx",
                "pkg:npm/formidable-oss-badges",
                "pkg:npm/react",
                "pkg:npm/react-dom"
            ]
        },
        {
            "ref": "pkg:npm/prism-react-renderer-monorepo/generate-prism-languages#packages/generate-prism-languages",
            "dependsOn": [
                "pkg:npm/react"
            ]
        },
        {
            "ref": "pkg:npm/prism-react-renderer-monorepo/prism-react-renderer#packages/prism-react-renderer",
            "dependsOn": [
                "pkg:npm/@types/prismjs",
                "pkg:npm/clsx"
            ]
        },
        {
            "ref": "pkg:npm/@ampproject/[email protected]",
            "dependsOn": [
                "pkg:npm/@jridgewell/[email protected]",
                "pkg:npm/@jridgewell/[email protected]"
            ]
        },......

Copy link

@justindeocampodd justindeocampodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Signed-off-by: Aryan Rajoria <[email protected]>
Signed-off-by: Aryan Rajoria <[email protected]>
Signed-off-by: Aryan Rajoria <[email protected]>
Signed-off-by: Aryan Rajoria <[email protected]>
Signed-off-by: Aryan Rajoria <[email protected]>
@prabhu
Copy link
Contributor

prabhu commented Sep 21, 2024

Any ideas about the test failures?

Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
Copy link
Collaborator Author

Any ideas about the test failures?

Yes have fixed

lib/helpers/utils.js Outdated Show resolved Hide resolved
lib/helpers/utils.js Outdated Show resolved Hide resolved
@prabhu prabhu merged commit 9e36e8e into master Sep 22, 2024
25 checks passed
@prabhu prabhu deleted the pnpm-imports branch September 22, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants