[Gradle] Fixed a problem with scoped NPM packages while resolving modules from NPM #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. Could we add any tests? |
malice00
force-pushed
the
fix/gradle_scoped_npm
branch
from
8457c76
to
6564187
Compare
|
Keep forgetting to lint before committing... |
Signed-off-by: Roland Asmann <[email protected]>
Signed-off-by: Roland Asmann <[email protected]>
malice00
force-pushed
the
fix/gradle_scoped_npm
branch
from
30499fd
to
4b3a6b1
Compare
|
@malice00 how do we handle the case where the namespace starts with "@"? This must be replaced to %40 for a valid purl |
|
@prabhu This is already handled -- I was already using the code that generates components for NPM. This fix was for then using the NPM-name in the Gradle command instead of the correct Gradle module's name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving the Gradle modules from NPM packages, there was an issue when the package was scoped. Because the package was referenced by its name, which in Gradle gets its scope added, the call to resolve dependencies used the wrong module-name.