Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain parent group and component across sub-projects. Fixes #474 again #481

Merged
merged 6 commits into from
Aug 23, 2023

Conversation

prabhu
Copy link
Collaborator

@prabhu prabhu commented Aug 22, 2023

Fixes #474

We need to thoroughly test with multiple gradle projects including android

Copy link
Contributor

@cerrussell cerrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting errors again for invalid control characters. Most likely more carriage returns like before. Overall test gradle projects did ok except I'm seeing more invalid ref warnings than I want to see - probably related to the first issue.

@cerrussell cerrussell self-requested a review August 22, 2023 09:16
Signed-off-by: Prabhu Subramanian <[email protected]>
@prabhu
Copy link
Collaborator Author

prabhu commented Aug 22, 2023

@cerrussell ready for retesting.

@prabhu
Copy link
Collaborator Author

prabhu commented Aug 22, 2023

@ajmalab @heubeck could you also test your internal repos with this branch?

Signed-off-by: Prabhu Subramanian <[email protected]>
@prabhu prabhu linked an issue Aug 22, 2023 that may be closed by this pull request
@heubeck
Copy link
Contributor

heubeck commented Aug 22, 2023

no issues for me: https://github.com/MediaMarktSaturn/technolinator/actions/runs/5942007543/job/16114050544

Signed-off-by: Prabhu Subramanian <[email protected]>
@malice00
Copy link
Contributor

OK, so with this branch, my test-project works correctly when run from the root of the multi-project Gradle-project.

When run from the single module that represents my release artifact, the parentComponent gets reset and I get this validation warning:

===== WARNINGS =====
[
  'Invalid ref in dependencies pkg:maven/at.test.cdxgen/[email protected]?type=jar'
]

When I run this branch on fineract v1.8.4, I get this warning:

===== WARNINGS =====
[
  'Found parent component with name fineract in metadata.component.components'
]

And finally, when I run it on the develop branch in fineract, same thing... And it seems to run forever!?

I guess we could put this one out there -- in multi-project mode all dependencies are there, so vuln-scans will work. Same for scanning a single project. The only thing that doesn't work (which I am not sure has ever worked in any current release, although I admit I haven't checked all releases) is the dependency-tree for a single project from a multi-project.

Signed-off-by: Prabhu Subramanian <[email protected]>
@prabhu
Copy link
Collaborator Author

prabhu commented Aug 23, 2023

Thanks @malice00. Let's collaborate offline to troubleshoot the single module issue. This branch is about fineract which works fine for both develop and release version of that repo.

@prabhu prabhu merged commit 8c90b9a into master Aug 23, 2023
7 checks passed
@prabhu prabhu deleted the fix/fineract-subcomp branch August 23, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants