-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain parent group and component across sub-projects. Fixes #474 again #481
Conversation
Signed-off-by: Prabhu Subramanian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting errors again for invalid control characters. Most likely more carriage returns like before. Overall test gradle projects did ok except I'm seeing more invalid ref warnings than I want to see - probably related to the first issue.
Signed-off-by: Prabhu Subramanian <[email protected]>
@cerrussell ready for retesting. |
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
OK, so with this branch, my test-project works correctly when run from the root of the multi-project Gradle-project. When run from the single module that represents my release artifact, the
When I run this branch on fineract v1.8.4, I get this warning:
And finally, when I run it on the develop branch in fineract, same thing... And it seems to run forever!? I guess we could put this one out there -- in multi-project mode all dependencies are there, so vuln-scans will work. Same for scanning a single project. The only thing that doesn't work (which I am not sure has ever worked in any current release, although I admit I haven't checked all releases) is the dependency-tree for a single project from a multi-project. |
Signed-off-by: Prabhu Subramanian <[email protected]>
Thanks @malice00. Let's collaborate offline to troubleshoot the single module issue. This branch is about fineract which works fine for both develop and release version of that repo. |
Fixes #474
We need to thoroughly test with multiple gradle projects including android