feat: metadata.component for poetry
#542
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -111,7 +111,7 @@ def get_output(self) -> BaseOutput: | |||
| '', | |||
| sep='\n', file=sys.stderr) | |||
|
|
|||
| bom = Bom(components=filter(self._component_filter, parser.get_components())) | |||
| bom = Bom(components=filter(self._component_filter, parser.get_components()), metadata=parser._metadata) | |||
There was a problem hiding this comment.
E1123: Unexpected keyword argument 'metadata' in constructor call
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
| @@ -111,7 +111,7 @@ def get_output(self) -> BaseOutput: | |||
| '', | |||
| sep='\n', file=sys.stderr) | |||
|
|
|||
| bom = Bom(components=filter(self._component_filter, parser.get_components())) | |||
| bom = Bom(components=filter(self._component_filter, parser.get_components()), metadata=parser._metadata) | |||
There was a problem hiding this comment.
reportGeneralTypeIssues: No parameter named "metadata"
❗❗ 2 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| cyclonedx_py/client.py | 114 |
| cyclonedx_py/parser/poetry.py | 104 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
| parser = PoetryFileParser(poetry_lock_filename=poetry_lock_filename, | ||
| use_purl_bom_ref=True, | ||
| poetry_toml_filename=poetry_toml_filename) | ||
| self.assertEqual('cyclonedx-bom', parser._metadata.component.name) |
There was a problem hiding this comment.
reportOptionalMemberAccess: "name" is not a known member of "None"
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
| @@ -111,7 +111,7 @@ def get_output(self) -> BaseOutput: | |||
| '', | |||
| sep='\n', file=sys.stderr) | |||
|
|
|||
| bom = Bom(components=filter(self._component_filter, parser.get_components())) | |||
| bom = Bom(components=filter(self._component_filter, parser.get_components()), metadata=parser._metadata) | |||
There was a problem hiding this comment.
❌ do not access protected/private properties!
use the public getters/properties!
There was a problem hiding this comment.
The current implementation of the BaseParser does not provide a get_metadata. Hence the direct access to the properties
There was a problem hiding this comment.
feel free to create one.
code is over here: https://github.com/CycloneDX/cyclonedx-python-lib/blob/main/cyclonedx/parser/__init__.py
There was a problem hiding this comment.
would you prefer to extend it in the python-lib or shall I write a ExtendedBaseParser in this project?
I would prefer the 2nd option as the first version would require to use the most current version of the python-lib then
| @@ -97,19 +99,29 @@ def __init__( | |||
| del error | |||
| self._components.append(component) | |||
|
|
|||
| if pyproject_toml_contents: | |||
| poetry_toml = load_toml(pyproject_toml_contents) | |||
| poetry_toml_metadata = poetry_toml.get('tool', '').get('poetry', '') | |||
There was a problem hiding this comment.
wrong types for defaults
- poetry_toml_metadata = poetry_toml.get('tool', '').get('poetry', '')
+ poetry_toml_metadata = poetry_toml.get('tool', {}).get('poetry', '')
jkowalleck
changed the title
metadata.component for poetry
|
converted this PR to "draft" as the target branch and source branch are not the desired ones. |
Signed-off-by: Aleg Vilinski <[email protected]>
Signed-off-by: Aleg Vilinski <[email protected]>
@jkowalleck could you please further elaborate? I forked the project and then made my changes on the branch dev/4.x.x there |
|
superseded by #605 |
This PR tries to address #391
Currently I only check for a pyproject.toml. As this will be used in combination with poetry I only added this feature there.