This repository has been archived by the owner on Apr 6, 2019. It is now read-only.
fix race condition in tcp_client::connect #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are right. This is curious that I didn't notice this before. |
Cylix
added a commit
that referenced
this pull request
Nov 27, 2015
fix race condition in tcp_client::connect
Closed
cmorse
pushed a commit
to cmorse/cpp_redis
that referenced
this pull request
Oct 18, 2017
Avoid using typedef names over full specialization.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race in the TCP client when connecting to the Redis host. The std::condition_variable is notified before the m_is_connected boolean is toggled possibly causing the connection to fail. This appears to happen very frequently in my setup.