Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exploit md5 hash to solve the limit of label on gitalk #41

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

TonyXie30
Copy link
Contributor

gitalk评论系统基于Github issues。gitalk会将文章名称转码添加到issues的label里,但是因为issues限制label长度仅为50,中文博客标题转码后非常容易超出长度,从而出现Error: Validation Failed错误。具体参照报错出现 Error: Validation Failed.
文章名经URL编码后转MD5,可以最大程度避免这个问题。在_config.yml添加gitalk的md5布尔值判断来启用该功能。

@D-Sketon D-Sketon merged commit 623f91f into D-Sketon:main Aug 24, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants