Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose kwargs redis #283

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Expose kwargs redis #283

merged 3 commits into from
Jul 24, 2024

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Jul 24, 2024

This is required if you want SSL, or changing the protocol, etc.

Changes

  • redis persister constructor
  • mongodb persister constructor

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

This is required if you want SSL, or changing the protocol, etc.
So that extra kwargs can be passed in.
To push kwargs exposure for redis & mongo persisters.
@skrawcz skrawcz merged commit e32dd29 into main Jul 24, 2024
11 checks passed
@skrawcz skrawcz deleted the expose_kwargs_redis branch July 24, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant