Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Favicon #401

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ayushsingh199
Copy link

@ayushsingh199 ayushsingh199 commented Oct 17, 2024

[Short description explaining the high-level reason for the pull request]

Changes

Added Favicon for the website!

Screenshot 2024-10-17 at 6 43 43 PM

Important

Add favicon to website by updating index.html to use burr-favicon.png.

  • HTML Update:
    • Added favicon by modifying the link tag in index.html to use burr-favicon.png as the icon.

This description was created by Ellipsis for a1dee60. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to a1dee60 in 18 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_yIDRVkXEwhjO965B


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

telemetry/ui/public/index.html Show resolved Hide resolved
@skrawcz
Copy link
Contributor

skrawcz commented Oct 18, 2024

Thanks @ayushsingh199. We also want this for the burr documentation page. I think you just need to do:

in conf.py under docs/

html_favicon = 'burr image file name' # and add the image to the docs folder too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants