Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Blocks Order Issue 189 #208

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

holbrookb
Copy link
Member

Allow blocks now always in same order as in conf file.

Allow blocks now always in same order as in conf file.
src/s_conf.c Outdated Show resolved Hide resolved
Remove current allow blocks too.
@eaescob eaescob requested a review from rscs April 5, 2022 22:36
A little cosmetic change
@eaescob eaescob linked an issue Apr 6, 2022 that may be closed by this pull request
Copy link
Contributor

@crigler crigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like remove_allows makes every struct Client's user->allow field become a dangling pointer to a now-freed entry from the old allows list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintain order of allow{} blocks.
3 participants