Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 409 #410

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Fix 409 #410

merged 2 commits into from
Jul 12, 2024

Conversation

d-chambers
Copy link
Contributor

Description

This PR fixes the metadata retrieval issue mentioned in #409, but it does not implement the custom DAS event format. We can do that in a latter PR if we really need to.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (99f4468) to head (f5870f7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         109      109           
  Lines        8843     8843           
=======================================
  Hits         8829     8829           
  Misses         14       14           
Flag Coverage Δ
unittests 99.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers merged commit 17c0237 into master Jul 12, 2024
15 checks passed
@d-chambers d-chambers deleted the fix_409 branch July 12, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant