Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FK(velocity/slope) filter #413

Merged
merged 6 commits into from
Jul 20, 2024
Merged

FK(velocity/slope) filter #413

merged 6 commits into from
Jul 20, 2024

Conversation

Shihao-Yuan
Copy link
Collaborator

Description

Implementing a frequency-wavenumber (F-K) filter to isolate seismic waves within a specified range of apparent velocities. This filter can also function as a directional filter, allowing for the selection of waves propagating in specific directions, such as upward/downward or leftward/rightward.

Relevant discussions #405

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@Shihao-Yuan Shihao-Yuan added the proc Related to processing module label Jul 17, 2024
@Shihao-Yuan Shihao-Yuan added the ready_for_review PR is ready for review label Jul 17, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (99f4468) to head (32b7c18).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         109      109           
  Lines        8843     8894   +51     
=======================================
+ Hits         8829     8880   +51     
  Misses         14       14           
Flag Coverage Δ
unittests 99.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers
Copy link
Contributor

Hey @Shihao-Yuan,

The failure above is caused by incomplete test coverage. When you click on the details you can see the lines that aren't covered. In this case, the problem was with the case where the input patch was already in the FK domain.

I just pushed a couple of tweaks. Mainly, I grouped the internal logic of slope_filter into sub functions just to improve organization. I also added some more tests and made the function general so it can work with dimensions of any name (not just time and distance).

Let me know what you think.

@d-chambers
Copy link
Contributor

@Shihao-Yuan, feel free to squash and merge when you are happy with the PR.

@Shihao-Yuan Shihao-Yuan merged commit 65fb430 into master Jul 20, 2024
15 checks passed
@d-chambers d-chambers deleted the proc-sy branch September 26, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proc Related to processing module ready_for_review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants