Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment identification tag in the header #483
base: main
Are you sure you want to change the base?
Add environment identification tag in the header #483
Changes from 26 commits
d00a2b8
e0af209
1e0ebba
d3252eb
903ecc7
98ad37d
3f9b108
78bdb5a
6f1d3d0
784cbdf
9a9767c
d8b2ee2
f8f7a75
a1506a9
b227314
8f7690b
97c71e6
3983e29
3d79afc
65ebffb
ab8e7f0
6a74d86
1fae189
6eb3b14
feeff41
01e308d
ad90acd
1579c60
bb1e773
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still thinking we should match these names to how they're used in URLs
We might want to use them to replace wildcards in URLs in future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will let @alexluckett decide that I think!
I don't have strong opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll ask on Slack
What shall we use when running locally?
Because the "dev" environment isn't local, e.g.
http://forms-designer.dev.cdp-int.defra.cloud
http://forms-runner.dev.cdp-int.defra.cloud
We'll need maybe
local
orlocalhost
as the default