Fix incorrect candidate bachelor degree equivalency #9958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a candidate inputs their degrees, they can chose an option called 'Another qualification equivalent to a degree'. This free text field will try to figure out if the value imputed is a bachelor degree or not. Previously we would just check if the free text search value is in our list of Bachelor degrees by checking if the string is included in the list. We didn't match the strings exactly. So if you have the correct keywords, like Bachelor of Medicine and Pixie hunting we would classify this degree as a bachelor degree because there is a valid bachelor degree called `Bachelor of Medicine`. This caused the form to break as there is no valid degree for Pixie hunting in the reference data gem. This commit checks the strings exactly to avoid this issue.
CatalinVoineag
temporarily deployed
to
review_aks
GitHub Actions
Inactive
CatalinVoineag
temporarily deployed
to
review_aks
GitHub Actions
Inactive
CatalinVoineag
temporarily deployed
to
review_aks
GitHub Actions
Inactive
elceebee
reviewed
Oct 21, 2024
| component = render_inline(described_class.new(application_form:)) | ||
| expect(component).to summarise( | ||
| key: 'Type of bachelor degree', | ||
| value: 'Bachelor of Arts in Architecture', |
There was a problem hiding this comment.
Do we want it to match if the user has inputted bachelor of arts in architecture? I'm happy to approve as it is -- we don't want to delay the bug fix thinking about what edge cases should / shouldn't be acceptable.
There was a problem hiding this comment.
Do you mean to make the component smart enough to know that it's a bachelor degree even if the capitalisation is not correct?
elceebee
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
I've tested on the review app and things work as expected.
I'm happy to approve as is -- might be worth considering weather we want it to match something that has just been typed lower case (bachelor of arts in architecture), but don't want to delay the bug fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When a candidate inputs their degrees, they can chose an option called 'Another qualification equivalent to a degree'. This free text field will try to figure out if the value imputed is a bachelor degree or not.
Previously we would just check if the free text search value is in our list of Bachelor degrees by checking if the string is included in the list. We didn't match the strings exactly.
So if you have the correct keywords, like Bachelor of Medicine and Pixie hunting we would classify this degree as a bachelor degree because there is a valid bachelor degree called
Bachelor of Medicine.This caused the form to break as there is no valid degree for Pixie hunting in the reference data gem.
This commit checks the strings exactly to avoid this issue. Fixing this sentry error
Changes proposed in this pull request
The
Type of bachelor degreeshould only be there for valid bachelor degreesGuidance to review
Go on review app and add a
Another qualification equivalent to a degreewith the keywords of a actual bachelor degree likeBachelor of MedicineThings to check