Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete compatibility #47

Merged
merged 5 commits into from
Aug 18, 2022
Merged

Autocomplete compatibility #47

merged 5 commits into from
Aug 18, 2022

Conversation

alaric-dfe
Copy link
Contributor

As per https://trello.com/c/wV2IRwEE/758-define-specifications-for-a-dropdown-compatible-reference-data-list

This PR formalises the concept of what structure a reference data list needs if it's to be put into an autocomplete-based selection thing such as dfe-autocomplete.

It:

  • Provides documentation of what an autocomplete-compatible list is
  • Marks what lists are autocomplete compatible (currently all of them!)
  • Provides a predicate on a reference data list to confirm that it is autocomplete-compatible
  • Adds RSpec tests that ensure all the supposedly autocomplete-compatible lists actually are
  • Fixes a small synonym duplication in the institutions list, which was breaking its autocomplete compatibility (yay for automated testing)

Good point!

Co-authored-by: Frankie Roberto <[email protected]>
@alaric-dfe alaric-dfe merged commit 904c3d5 into main Aug 18, 2022
@alaric-dfe alaric-dfe deleted the autocomplete-list-spec branch August 18, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants