Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Institute of Chartered Accountants of Scotland' to institutions #55

Merged

Conversation

jhenderson
Copy link
Contributor

@jhenderson jhenderson commented Sep 15, 2022

Context

https://trello.com/c/9qNctNxM/4652-register-trainee-teachers

A provider cannot find the closest match, so a request has been made by support to add it to the list of institutions.

Changes proposed in this pull request

  • Add The Institute of Chartered Accountants of Scotland to INSTITUTIONS

@frankieroberto
Copy link
Contributor

@jhenderson can you confirm whether this institution has degree awarding powers in Scotland or not? They don't seem to be in this list, but possibly that's not up-to-date? https://www.gov.scot/policies/universities/

If they don't award "degrees" but do award equivalent qualifications, we can still add them to the list, adding 'has_never_awarded_degrees' => true. This helps us validate degree qualifications (in theory).

@edwardhorsford
Copy link
Contributor

I don't think we should add this. This list aims to have all UK degree awarding institutions - which I don't think this is.

This has come about because a provider has attempted to add an accounting qualification to Register. But I suspect we don't want to know about the accounting qualification as it isn't relevant to their teacher training.

What this does highlight is that Register (and this list) don't have any generic options for where an institution is missing - we should add something for this.

@jhenderson jhenderson force-pushed the add-chartered-accountants-of-scotland-to-institutions branch from 74c70e4 to da6a5e6 Compare September 15, 2022 14:21
@jhenderson jhenderson force-pushed the add-chartered-accountants-of-scotland-to-institutions branch from da6a5e6 to 4626116 Compare September 20, 2022 11:11
@edwardhorsford
Copy link
Contributor

To summarise some offline conversations:

This institution isn't degree awarding, so arguably doesn't belong in this list. However, the list already contains many non-degree awarding institutions as a result of HESA including them - so one more doesn't make a big difference. We have a flag that can mark something as non-degree awarding. As this is blocking a user from proceeding, we'll add the item. Services can choose to suppress non-degree awarding institutions from appearing if they choose.

In short term we will also look at adding a 'catch all' generic option of "Other institution" - which could be used in cases like this.

@jhenderson jhenderson merged commit 4a11f49 into main Sep 20, 2022
@jhenderson jhenderson deleted the add-chartered-accountants-of-scotland-to-institutions branch September 20, 2022 15:03
Copy link
Contributor

@alaric-dfe alaric-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the hash keys! Not sure how that slipped through in the original data import... Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants