New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7650] Amended to read csv as hash #4722

Open

defong wants to merge 1 commit into main from 7650-fixed-degreee-csv-specs

+34 −8

Contributor

defong commented Oct 16, 2024

Context

Failing specs

Changes proposed in this pull request

Amended to read csv as hash

Guidance to review

bundle exec rspec ./spec/services/

Important business

Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
Do we need to send any updates to DQT as part of the work in this PR?
Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

Contributor Author

defong commented Oct 16, 2024

Fix flaky tests on code coverage full test runs


          [7650] Amended to read csv as hash

4b6ecab

defong force-pushed the 7650-fixed-degreee-csv-specs branch from 0d9ec79 to 4b6ecab Compare

October 17, 2024 08:48

sonarcloud bot commented Oct 17, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet