-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Back port of the StatisticS class of ImaGene #1076
Back port of the StatisticS class of ImaGene #1076
Conversation
SECTION("Testing feature math of MultiStatistics without saving data") | ||
{ | ||
unsigned int val = 50; | ||
REQUIRE( (stats.max(val) == val) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the double (), you don't need them anymore and it will prevent nice Catch outputs of the test fails otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also please do it elsewhere ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes thanks
At this point, there is no documentation at all on the statistical tools (Statistic, histogram, LinearRegression...). Maybe we should start writing something. We can do it together if you want. |
Yes thanks, we can do it together, in a new module section you mean ? |
Yes, a module page in the math package. |
ok perhaps in other PR ? |
very nice then on use () of to display info! |
* stores a set of sample values for several variables and can then | ||
* compute different statistics, like sample mean, sample variance, | ||
* sample unbiased variance, etc. | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you should add a note to make clear that a "terminale()" before accessing quantities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree thanks
Thanks for the review, that done |
done ;) |
great.. thanks.. |
Back port of the StatisticS class of ImaGene
Todo: