Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back port of the StatisticS class of ImaGene #1076

Merged
merged 13 commits into from
Nov 30, 2015

Conversation

kerautret
Copy link
Member

Todo:

  • backport main imagene class
  • add catch test
  • check DGtal naming
  • complete doc

SECTION("Testing feature math of MultiStatistics without saving data")
{
unsigned int val = 50;
REQUIRE( (stats.max(val) == val) );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the double (), you don't need them anymore and it will prevent nice Catch outputs of the test fails otherwise

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also please do it elsewhere ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes thanks

@dcoeurjo
Copy link
Member

At this point, there is no documentation at all on the statistical tools (Statistic, histogram, LinearRegression...). Maybe we should start writing something. We can do it together if you want.

@kerautret
Copy link
Member Author

Yes thanks, we can do it together, in a new module section you mean ?

@dcoeurjo
Copy link
Member

Yes, a module page in the math package.

@kerautret
Copy link
Member Author

ok perhaps in other PR ?
Else I just apply the catch changes, I check it also in other PR.

@kerautret
Copy link
Member Author

very nice then on use () of to display info!

* stores a set of sample values for several variables and can then
* compute different statistics, like sample mean, sample variance,
* sample unbiased variance, etc.
*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should add a note to make clear that a "terminale()" before accessing quantities

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree thanks

@kerautret
Copy link
Member Author

Thanks for the review, that done

@kerautret
Copy link
Member Author

done ;)

@dcoeurjo
Copy link
Member

great.. thanks..
merging.

dcoeurjo added a commit that referenced this pull request Nov 30, 2015
Back port of the StatisticS class of ImaGene
@dcoeurjo dcoeurjo merged commit afe9b53 into DGtal-team:master Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants