-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding raw I/O capabilities for non integral types and signed integers. #1084
Conversation
Tricky bugfix, thanks. |
Done. I have added writer test in the reader test file. |
} | ||
|
||
/* | ||
TEST_CASE( "Checking writing & reading double in 4D with generic IO", "[reader][writer][4D][raw][double]" ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code cleanup ?
thanks for the test. I only have a minor comment |
Done ;) |
Thanks |
Added. |
In I meant |
Haa ok. Should I also update GenericReader and GenericWriter to allow I/O on any type ? Currently, only 8bits and 32bits raw file are supported. |
I don't know for GenericWriter/Reader since the extension is used to switch between formats (with implicit cast if the Image value type is not the same). |
It seems that the extension is always "raw" and that the value type if deduced from the Image::Value type. I'll give it a try ;) |
Done. I have also fixed some bugs in GenericReader/Writer. By the way, those files are not very understandable and it is not clear whether the same ( file format, value type ) pairs are supported by both classes. With |
Thanks a lot. |
Adding raw I/O capabilities for non integral types and signed integers.
E.g. works with
double
orint
usingexportRaw
andimportRaw
methods.Note: in the writer,
put
accept astd::ostream::char_type
which is, by default, achar
. So, I don't understand why the conversion from anunsigned char
don't not lead to a bug ...