add getFaceCenter method #1091
Merged
add getFaceCenter method #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for ( auto &j: aFace){ | ||
| c += getVertex(j); | ||
| } | ||
| return c/aFace.size(); |
There was a problem hiding this comment.
implicit cast to int (or size_t) ?
There was a problem hiding this comment.
yes ok I add a static_cast
|
done thanks |
| for ( auto &j: aFace){ | ||
| c += getVertex(j); | ||
| } | ||
| return c/static_cast<typename TPoint::Component>(aFace.size()); |
There was a problem hiding this comment.
well.. yes.. but If the mesh has integer coordinates vertices, the barycenter is a bit crappy since it may not lie on the surface.
There was a problem hiding this comment.
maybe you should make this clear. Or decide that the output of "getbarycenter" is always a "RealPoint" and thus cast to double the denominator
There was a problem hiding this comment.
ok for RealPoint it is more logic
|
Ok fine. |
|
yes done ;) |
|
thanks merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny PR just to lighten some codes.