Explicit Instantiation of some Z2i/Z3i classes #1117
Conversation
dcoeurjo
commented
Jan 22, 2016
dcoeurjo
commented
- cleanup of some cpp included in libDGtal
- explicit instantiation of some Z2i:: and Z3i:: classes
- this PR (slightly) speeds up unit test build
|
Can someone have a quick look at this PR ? |
| @@ -311,7 +311,7 @@ DGtal::ExactPredicateLpPowerSeparableMetric<T,2,P>::binarySearchHidden(const Abs | |||
| const Abscissa &/*upper*/) const | |||
| { | |||
| ASSERT(false && "Not Necessary for l_2"); | |||
|
|
|||
| return 0; | |||
There was a problem hiding this comment.
Should we not better thrown an exception or simply not define this function (only the header) ?
There was a problem hiding this comment.
Maybe not the right place to talk about this, but there is a lake of DGtal exceptions, especially with a string member to describe why an exception was raised (e.g. in DGtal::IOException).
There was a problem hiding this comment.
Le 22 janv. 2016 à 15:02, rolanddenis [email protected] a écrit :
In src/DGtal/geometry/volumes/distance/ExactPredicateLpPowerSeparableMetric.ih #1117 (comment):
@@ -311,7 +311,7 @@ DGtal::ExactPredicateLpPowerSeparableMetric<T,2,P>::binarySearchHidden(const Abs
const Abscissa &/upper/) const
{ASSERT(false && "Not Necessary for l_2");
- return 0;
Maybe not the right place to talk about this, but there is a lake of DGtal exceptions, especially with a string member to describe why an exception was raised (e.g. in DGtal::IOException).
I definitely agree… Exception management in DGtal is very limited.
|
Nice Idea ! |
|
Merging;) |
Explicit Instantiation of some Z2i/Z3i classes
