Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc examples listing #1166

Merged
merged 25 commits into from
Jun 20, 2016
Merged

Doc examples listing #1166

merged 25 commits into from
Jun 20, 2016

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented May 7, 2016

PR Description

Add examples when missing in section http://liris.cnrs.fr/dgtal/doc/nightly/examples.html

Checklist

  • [n.a] Unit-test of your feature with Catch.
  • [n.a] Doxygen documentation of the code completed (classes, methods, types, members...)
  • [n.a] Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

- exampleDiscreteExteriorCalculusUsage.cpp
- exampleDiscreteExteriorCalculusSolve.cpp
- examplePropagation.cpp
- exampleDiscreteExteriorCalculusChladni.cpp
- testDiscreteExteriorCalculus.cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test files shouldn't be used as examples

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was already here (juste a move) ;)

@dcoeurjo
Copy link
Member

@kerautret, we've discussed with @rolanddenis about doxygen issues in the documentation. To clarify the "@example" file description, what do you think to:

  • ask the authors to document all example files
  • move the doxygen example file description from the module pages into the example file (similarly to what you did in the tools)

what do you think?



/**
Example of Discrete Exterior Calculus with Chladni.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an example to my comment: \example and @example must be moved to the example source code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kerautret, we've discussed with @rolanddenis about doxygen issues in the documentation. To clarify the "@example" file description, what do you think to:
ask the authors to document all example files

yes sure, now we can easily see with this PR which example should be completed.
But not sure that it implies a lot of doc comments since in general they are well given in the main module doc. Perhaps just to check if the short description of the example is ok and to check if the link to the doc module part exist.

move the doxygen example file description from the module pages into the example file (similarly to what you did in the tools)

yes, It should be a good idea and it could be more easy to check if all examples where documented ;)

@@ -22,6 +22,11 @@
- Add cmake configuration file NeighborhoodTablesConfig to
decompress and install look up tables. (Pablo Hernandez-Cerdan,
[#1155](https://github.com/DGtal-team/DGtal/pull/1155))
<<<<<<< HEAD
- Check and add all DGtal examples in the Examples listing section.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

@dcoeurjo
Copy link
Member

Excellent, merging.

@dcoeurjo dcoeurjo merged commit 8cfa0f2 into DGtal-team:master Jun 20, 2016
@dcoeurjo
Copy link
Member

Opening Issue #1191 to keep track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants