-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc examples listing #1166
Doc examples listing #1166
Conversation
- exampleDiscreteExteriorCalculusUsage.cpp | ||
- exampleDiscreteExteriorCalculusSolve.cpp | ||
- examplePropagation.cpp | ||
- exampleDiscreteExteriorCalculusChladni.cpp | ||
- testDiscreteExteriorCalculus.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test files shouldn't be used as examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was already here (juste a move) ;)
@kerautret, we've discussed with @rolanddenis about doxygen issues in the documentation. To clarify the "@example" file description, what do you think to:
what do you think? |
|
||
|
||
/** | ||
Example of Discrete Exterior Calculus with Chladni. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an example to my comment: \example and @example must be moved to the example source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kerautret, we've discussed with @rolanddenis about doxygen issues in the documentation. To clarify the "@example" file description, what do you think to:
ask the authors to document all example files
yes sure, now we can easily see with this PR which example should be completed.
But not sure that it implies a lot of doc comments since in general they are well given in the main module doc. Perhaps just to check if the short description of the example is ok and to check if the link to the doc module part exist.
move the doxygen example file description from the module pages into the example file (similarly to what you did in the tools)
yes, It should be a good idea and it could be more easy to check if all examples where documented ;)
@@ -22,6 +22,11 @@ | |||
- Add cmake configuration file NeighborhoodTablesConfig to | |||
decompress and install look up tables. (Pablo Hernandez-Cerdan, | |||
[#1155](https://github.com/DGtal-team/DGtal/pull/1155)) | |||
<<<<<<< HEAD | |||
- Check and add all DGtal examples in the Examples listing section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
;)
Excellent, merging. |
Opening Issue #1191 to keep track. |
PR Description
Add examples when missing in section http://liris.cnrs.fr/dgtal/doc/nightly/examples.html
Checklist
cmake
mode (otherwise, Travis C.I. will fail).