Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit M_PI definition #1208

Merged
merged 2 commits into from
Oct 17, 2016
Merged

Explicit M_PI definition #1208

merged 2 commits into from
Oct 17, 2016

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Sep 30, 2016 •
edited
Loading

PR Description

Explicit definition of M_PI is not defined in cmath or math.h. (see #1204)

Checklist

  • [n.a.] Unit-test of your feature with Catch.
  • [n.a.] Doxygen documentation of the code completed (classes, methods, types, members...)
  • [n.a.] Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo dcoeurjo mentioned this pull request Sep 30, 2016
Closed
@dcoeurjo dcoeurjo self-assigned this Sep 30, 2016
@dcoeurjo dcoeurjo modified the milestones: 0.9.2, 0.9.3 Sep 30, 2016
@kerautret
Copy link
Member

looks fine according the #1204 issue ;) merging

@kerautret kerautret merged commit ac2479e into DGtal-team:master Oct 17, 2016
@dcoeurjo dcoeurjo deleted the M_PI branch October 18, 2016 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dcoeurjo dcoeurjo

Labels
Base Build ready for review 👍
Projects
None yet
Milestone
0.9.3
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoeurjo @kerautret