-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compressed Vol format #1228
Compressed Vol format #1228
Conversation
this PR depends on #1227 |
@kerautret I think I would need your help to download and install zlib DLLs on appeveyor windows script. The DLL is available here: http://www.winimage.com/zLibDll/ but I don't know of to deal with the appeveyor script. |
Nice features ! Yes I will look it ! |
Current behavior is to decompress tables at cmake level, wasting HDD space of user. Depends on PR DGtal-team#1228 that adds zlib dependency. Discussion and motivation on Issue DGtal-team#1229.
FYI: here you have a simple command line tool to convert compressed vol to raw https://github.com/dcoeurjo/VolGallery/blob/master/tools/vol2raw.sh (yup, the compressed part can be decompressed using gzip with the appropriate header 😄 ) |
install zlib remote
Zlib app veyor fix
The appveyor script is now ok (thanks @kerautret ). The DGtalTools target is still failing on travis but a DGtaltools pending PR has a fix. Can someone have a look to the code so that I can merge this PR ? thx |
Current behavior is to decompress tables at cmake level, wasting HDD space of user. Depends on PR DGtal-team#1228 that adds zlib dependency. Discussion and motivation on Issue DGtal-team#1229.
yes I look it for the DGtalTools ;) |
I reloaded Travis from the DGtools merged ;) |
Current behavior is to decompress tables at cmake level, wasting HDD space of user. Depends on PR DGtal-team#1228 that adds zlib dependency. Discussion and motivation on Issue DGtal-team#1229.
@dcoeurjo sorry I have included the master in the PR on your branch ;( |
no problemo;) |
Okay.. bots look fine. Merging this dude. |
PR Description
This PR adds a new Version (3) to Vol file format allowing to have compressed volumetric data using zlib. In Version 2, vol consists in an ASCII header and then the raw data in binary mode. This new version compresses the raw data using zlib/boost-filter, saving huge storage.
VolReader and VolWriter have been updated and can still import/export Version 2 vols.
To be able to perform such compression, zlib must be installed in the system (and is thus a new mandatory dependency in DGtal). This lib is highly standard and shouldn't be a problem. I could have make this dependency optional but if you all agree, I would like this "compressed" version to be the default one.
I've planned a
upgradeVol
tool to upgrade a vol file from Version 2 to 3 inDGtalTools
.Additionaly, the Boost lib filter I use needs boost>1.50.
🎄 🎁 🎄
TODO
Checklist
cmake
mode (otherwise, Travis C.I. will fail).