-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] SimpleMatrix with initializer_list constructor #1250
[WIP] SimpleMatrix with initializer_list constructor #1250
Conversation
…pleMatrix-initialization
…mand/DGtal into SimpleMatrix-initialization
hi @nnormand , I'm on it. Could you please add a test in testSimpleMatrix ? |
I agree.. cofactor must be updated before returning the determinant or "cofactor" methods. |
fine. can someone review this PR ? |
I will try to review it this week. One remark: it would be nice to have a non-invasive editor, so that unrelated files are not modified. Here there are 22 files changed, whereas certainly one or two are concerned. |
This PR also contains the new .clang-format rules in a previous PR. My push uses this rules to auto-format the modified file. I don't understand why other files have been processed BTW |
you only have to review SimpleMatrix constructor. |
Ok. No problem. I will try to review it tonight. |
I only looked at SimpleMatrix.* and testSimpleMatrix.cpp. It is fine with me. My only remark is to add in the initialiser_list constructor the fact that matrices are filled in row by row from top left to top right then again to bottom. |
agree |
I've updated the doc of the constructor. Fine for you ? |
It is fine with me. I've restarted the travis job that fails because of excess time. |
This PR adds a constructor for SimpleMatrix with an initializer_list argument. This is work in progress: the cofactors are NOT computed and it is unclear if they should or not (
setComponent
doesn't).Checklist
cmake
mode (otherwise, Travis C.I. will fail).