Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix light source move in Viewer3D #1262

Merged
merged 3 commits into from
Jun 4, 2017
Merged

fix light source move in Viewer3D #1262

merged 3 commits into from
Jun 4, 2017

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Apr 18, 2017 •
edited
Loading

PR Description

Very small PR just to fix light source direction which very difficult to set from mouse move.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo
Copy link
Member

dcoeurjo commented Jun 4, 2017

very nice
Merging, thanks

@dcoeurjo dcoeurjo closed this Jun 4, 2017
@dcoeurjo dcoeurjo reopened this Jun 4, 2017
@dcoeurjo dcoeurjo merged commit c5aac64 into DGtal-team:master Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerautret @dcoeurjo