Fixing documentation checks and updating Travis build

[rolanddenis]

PR Description

Fixing documentation checks that was not fully done (see #1334)

Checklist

• Doxygen documentation of the code completed (classes, methods, types, members...)
• New entry in the ChangeLog.md added.
• All continuous integration tests pass (Travis & appveyor)
• Fixing all doxygen warnings
• [ ] Adding @example tag check

[dcoeurjo]

Many thanks @rolanddenis for this PR ;)
I just have a minor comment. Could you please also add an entry in the Changelog?

[dcoeurjo]

why these one have been commented ?

[rolanddenis]

It is a copy-paste from .travis/main_build.sh:

DGtal/.travis/main_build.sh

Line 16 in 8f3ca8c

#make exampleDiscreteExteriorCalculusSolve;

and it has been commented in 163a835 from #1306 but I don't know why (@kerautret ?).

I will try to uncomment these lines

[kerautret]

It was to try to avoid the segfault or timeout issue of travis due to gcc problem (as discussed with Jaco in last meeting). Changing the moment where it was compiled fixed the memory issue (I suppose), but perhaps we have to remove this example from the travis test.

[rolanddenis]

In fact, these two examples are already built during the main build. This part is only for examples that need to be build alone in order to avoid compiler failures. I think we can remove these two lines ...

[rolanddenis]

Oups, didn't see your answer 😉

[kerautret]

yes of course if they are in the main part, but it was commented because it was an alternative.
But this part is not robust in all cases.

[kerautret]

I was wondering ;)

[rolanddenis]

About the ChangeLog.md, I've already add an entry (see https://github.com/DGtal-team/DGtal/pull/1335/files#diff-e705c8fadf1193ab59443a5e6c8cbe8b) 😉

[dcoeurjo]

Oops.. sorry ;)
Thanks for the PR

Just a quick question where do the SCRIPTBEGIN/END come from ?

[rolanddenis]

They are defined in .travis/before_global.sh:

DGtal/.travis/before_global.sh

Line 13 in f879fc4

export SCRIPT_BEGIN="set -$SET_OPTIONS"

The idea is to set and reset some flags useful for debugging Travis, like the set -e that was already set in some scripts before this PR and that make a script returning a non-zero value if any of its command fails. We can also add v to view each executed commands. The SCRIPT_END resets the flags (because some scripts always have errors, like .travis/install_deps_macos.sh and Travis also have a strange behaviour when the e flag is set) and resets the working directory.

[rolanddenis]

But it seems that it doesn't always work 😕 : the Travis job associated to the merge has successful ended (see https://travis-ci.org/DGtal-team/DGtal/builds/404334020 ) but the .travis/publish_doc.sh has partially failed (see the end of https://api.travis-ci.org/v3/job/409458892/log.txt ). So the documentation is up to date, but not the tags and docset ...