Remove Object from VoxelComplex #1369
Merged
+496
−607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phcerdan
force-pushed
the
remove_object_from_voxel_complex
branch
5 times, most recently
from
c0bb843
to
c2f7f6f
Compare
phcerdan
added a commit
to phcerdan/DGtalTools
that referenced
this pull request
Nov 29, 2018
phcerdan
added a commit
to phcerdan/DGtalTools
that referenced
this pull request
Nov 29, 2018
phcerdan
force-pushed
the
remove_object_from_voxel_complex
branch
2 times, most recently
from
fc510bc
to
5e9f141
Compare
|
I fixed CI errors. Travis-ci is red because compiling timeout, CMake failing to configure with doxygen, and the DGtal Tools is failing, but PR opened at: DGtal-team/DGtalTools#345. |
|
PR pending for doxygen (#1372). Thx |
phcerdan
added a commit
to phcerdan/SGEXT
that referenced
this pull request
Dec 19, 2018
Remove NoObject from VoxelComplex DGtal-team/DGtal#1369
phcerdan
added a commit
to phcerdan/SGEXT
that referenced
this pull request
Dec 19, 2018
Remove NoObject from VoxelComplex DGtal-team/DGtal#1369
|
How can I help to move this forward? I have a few scripts pending on this update. |
|
sorry..very busy these last weeks. I'll give you some feedbacks asap |
|
Hi @phcerdan can you please merge the master to this branch ? All travis issues should disappear. |
|
Will do after new year, thanks!
… On 29 Dec 2018, at 05:01, David Coeurjolly ***@***.***> wrote:
Hi @phcerdan can you please merge the master to this branch ? All travis issues should disappear.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
phcerdan
force-pushed
the
remove_object_from_voxel_complex
branch
from
5e9f141
to
b2c35c1
Compare
|
done, rebased on top of master. |
dcoeurjo
requested changes
Jan 5, 2019
phcerdan
force-pushed
the
remove_object_from_voxel_complex
branch
from
b2c35c1
to
8e180ab
Compare
This drops the runtime by ~4x (orientative) And the memory usage (not quantified). Also reduce time of testing. Fix DGtal-team#1347
phcerdan
force-pushed
the
remove_object_from_voxel_complex
branch
from
8e180ab
to
1d87cee
Compare
|
Thanks @dcoeurjo! 🎉 |
phcerdan
added a commit
to phcerdan/SGEXT
that referenced
this pull request
Jan 7, 2019
Remove NoObject from VoxelComplex DGtal-team/DGtal#1369
phcerdan
added a commit
to phcerdan/DGtalTools
that referenced
this pull request
Jan 17, 2019
phcerdan
added a commit
to phcerdan/DGtalTools
that referenced
this pull request
Jan 18, 2019
phcerdan
added a commit
to phcerdan/DGtalTools
that referenced
this pull request
Jan 18, 2019
phcerdan
added a commit
to phcerdan/DGtalTools
that referenced
this pull request
Jan 19, 2019
phcerdan
added a commit
to phcerdan/SGEXT
that referenced
this pull request
Jan 26, 2021
Remove NoObject from VoxelComplex DGtal-team/DGtal#1369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the runtime by ~4x (orientative)
And the memory usage (not quantified).
Also reduce time of testing. Fix #1347
cmakemode (otherwise, Travis C.I. will fail).