Fix Travis (documentation deploy & DGtalTools) #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolanddenis
force-pushed
the
test_travis
branch
from
ea1122d
to
11daf1c
Compare
rolanddenis
changed the title
dcoeurjo
reviewed
Jan 18, 2019
.travis/build_all.sh
Outdated
|
|
||
| #Sequential DEC examples, this would also build library | ||
| #make examplePropagation | ||
| ninja testDiscreteExteriorCalculusExtended | ||
| #make exampleDiscreteExteriorCalculusChladni | ||
| ninja | ||
| ninja install |
There was a problem hiding this comment.
Thus (following the comment below), it is not necessary here since we don't use DGtal after this compilation. I only add this to copy the build_dgtal.sh script ... should I remove it ?
| ninja | ||
| ninja install |
There was a problem hiding this comment.
Because when compiling DGtalTools, I don't rely anymore on a DGtal_DIR variable but instead use CMAKE_PREFIX_PATH set to the dependency installation folder and let CMake find DGtal by itself. To be sure that files are at the good place, I have preferred to use the installation procedure (that also mimics what user may do to install DGtal).
rolanddenis
force-pushed
the
test_travis
branch
from
11daf1c
to
5a1ab24
Compare
rolanddenis
force-pushed
the
test_travis
branch
from
5a1ab24
to
5ca0ac8
Compare
|
Thanks @rolanddenis , merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Update and fix of Travis script:
PATH,CPATHandCMAKE_PREFIX_PATH) instead of keeping path of each dependency.Checklist
cmakemode (otherwise, Travis C.I. will fail).