Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and refactor NumberTraits #1397

Merged
merged 4 commits into from
Mar 14, 2019
Merged

Fix and refactor NumberTraits #1397

merged 4 commits into from
Mar 14, 2019

Conversation

rolanddenis
Copy link
Member

@rolanddenis rolanddenis commented Feb 22, 2019 •
edited
Loading

PR Description

Fix issues with NumberTraits (see #1396) and refactor this class by relying on std::numeric_limits when possible (i.e. for all fundamental arithmetical types).

Also add a test file for NumberTraits.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@rolanddenis
Adding test for NumberTraits class.
ce2e0ee 
And adding static properties definition for currently non-specialized
types (long long int).
@rolanddenis
Add the WITH_BIGINTEGER predefined macro in doxygen config.
1910160 
So that to have associated documentation generated.
@rolanddenis
Refactoring of NumberTraits and adding long long int support.
856d050 
It now relies mainly on std::numeric_limits for fundamental types so
that we don't need a specialization per type anymore.

Also fix some wrong type traits (digits of floating-point types and
                                 BigInteger bound status).
@rolanddenis
Update ChangeLog.md
1308374 
Also remove an unwanted quote.
@dcoeurjo
Copy link
Member

dcoeurjo commented Mar 5, 2019

thanks @rolanddenis .. reviewing ;)

@dcoeurjo
Copy link
Member

well you're way more skilled than me for this kind of type related stuffs...

@dcoeurjo dcoeurjo self-requested a review March 14, 2019 16:33
@dcoeurjo
Copy link
Member

Let's merge this one;) thx

@dcoeurjo dcoeurjo merged commit cceb3a6 into DGtal-team:master Mar 14, 2019
@rolanddenis rolanddenis deleted the fix_numbertraits branch March 14, 2019 17:06
@rolanddenis rolanddenis mentioned this pull request Mar 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoeurjo dcoeurjo Awaiting requested review from dcoeurjo

Assignees
No one assigned
Labels
Kernel ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolanddenis @dcoeurjo