Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix1478 #1481

Merged
merged 4 commits into from
Apr 22, 2020
Merged

Fix1478 #1481

merged 4 commits into from
Apr 22, 2020

Conversation

JacquesOlivierLachaud
Copy link
Member

@JacquesOlivierLachaud JacquesOlivierLachaud commented Apr 21, 2020 •
edited
Loading

PR Description

Fix issue #1478. VisualStudio 2019 does not accept friend specialization declaration of operators in CubicalComplex. Modify code to befriend all template CubicalComplex operators.

Checklist

  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

kerautret
kerautret approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks we can merge, just typo in the issue version ;)

ChangeLog.md Outdated Show resolved Hide resolved
@kerautret kerautret merged commit 56ea2f1 into DGtal-team:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerautret kerautret kerautret approved these changes

Assignees
No one assigned
Labels
Build Compilation Issue Topology waiting author feedbacks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JacquesOlivierLachaud @kerautret