Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Fix CMAKE_C_FLAGS when WITH_OPENMP=ON #1495

Merged
merged 1 commit into from
May 27, 2020
Merged

CMake: Fix CMAKE_C_FLAGS when WITH_OPENMP=ON #1495

merged 1 commit into from
May 27, 2020

Conversation

phcerdan
Copy link
Member

@phcerdan phcerdan commented May 26, 2020 •
edited
Loading

CMAKE_C_FLAGS was set to the value of CMAKE_CXX_FLAGS when WITH_OPENMP=ON

Checklist

  • [NA] Unit-test of your feature with Catch.
  • [NA] Doxygen documentation of the code completed (classes, methods, types, members...)
  • [NA] Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@phcerdan
CMake: Fix CMAKE_C_FLAGS when WITH_OPENMP=ON
53f6627 
`CMAKE_C_FLAGS` was set to the value of `CMAKE_CXX_FLAGS` when `WITH_OPENMP=ON`
@phcerdan phcerdan force-pushed the fix_with_openmp_cmake_c_flags branch from 2d4702c to 53f6627 Compare May 26, 2020 11:07
@dcoeurjo dcoeurjo self-requested a review May 27, 2020 12:48
dcoeurjo
dcoeurjo approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phcerdan

@dcoeurjo dcoeurjo merged commit 21eef21 into DGtal-team:master May 27, 2020
@phcerdan phcerdan deleted the fix_with_openmp_cmake_c_flags branch May 27, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoeurjo dcoeurjo dcoeurjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phcerdan @dcoeurjo