Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fillData in CubicalComplex #1519

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Fix fillData in CubicalComplex #1519

merged 1 commit into from
Oct 7, 2020

Conversation

phcerdan
Copy link
Member

@phcerdan phcerdan commented Oct 7, 2020

It was calling clear instead of fill

Checklist

  • [NA] Unit-test of your feature with Catch.
  • [NA] Doxygen documentation of the code completed (classes, methods, types, members...)
  • [NA] Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@phcerdan
Fix fillData in CubicalComplex
0bfdee9 
It was calling clear instead of fill
@phcerdan phcerdan force-pushed the fix_fillData_cubical_complex branch from 3c1a2b5 to 0bfdee9 Compare October 7, 2020 10:56
@dcoeurjo
Copy link
Member

dcoeurjo commented Oct 7, 2020

👍

@dcoeurjo dcoeurjo self-requested a review October 7, 2020 12:07
@dcoeurjo dcoeurjo merged commit e11b04e into DGtal-team:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoeurjo dcoeurjo dcoeurjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phcerdan @dcoeurjo