Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Color::getRGBA #1535

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Fix Color::getRGBA #1535

merged 1 commit into from
Nov 27, 2020

Conversation

phcerdan
Copy link
Member

@phcerdan phcerdan commented Nov 27, 2020 •
edited
Loading

Also add a default alpha to setRGBi for consistency with all the other
methods.

Spotted testing the wrappings in python.

Checklist

  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@phcerdan
Fix Color::getRGBA
5ab4045 
Also add a default alpha to setRGBi for consistency with all the other
methods.

Spotted testing the wrappings in python.
dcoeurjo
dcoeurjo approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooch ;) many thanks @phcerdan

@phcerdan phcerdan merged commit 5938e55 into DGtal-team:master Nov 27, 2020
@phcerdan phcerdan deleted the fix_Color_getRGBA branch November 27, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoeurjo dcoeurjo dcoeurjo approved these changes

@rolanddenis rolanddenis Awaiting requested review from rolanddenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phcerdan @dcoeurjo