Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normal vector estimation based on plane-probing approaches #1547

Merged
merged 74 commits into from
Feb 23, 2021
Merged

Normal vector estimation based on plane-probing approaches #1547

merged 74 commits into from
Feb 23, 2021

Commits on Feb 3, 2021

  1. Add DigitalPlanePredicate class

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    a8b456a View commit details
    Browse the repository at this point in the history

  2. DigitalPlanePredicate is a model of CPointPredicate and add a test

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    0bd1340 View commit details
    Browse the repository at this point in the history

  3. Fix doc of ParallelStrip (replace \dot by \cdot)

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    16e06d6 View commit details
    Browse the repository at this point in the history

  4. Add utility types and functions for plane probing estimators

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    ba49d59 View commit details
    Browse the repository at this point in the history

  5. Add PlaneProbingNeighborhood and its subclass PlaneProbingHNeighborhood

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    b022226 View commit details
    Browse the repository at this point in the history

  6. Add PlaneProbingTetrahedronEstimator and an example program

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    fd877ed View commit details
    Browse the repository at this point in the history

  7. Add PlaneProbingRNeighborhood

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    b0754e0 View commit details
    Browse the repository at this point in the history

  8. Add PlaneProbingR1Neighborhood

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    4c3699e View commit details
    Browse the repository at this point in the history

  9. Remove useless types and functions from DGtal::detail namespace

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    a3f7770 View commit details
    Browse the repository at this point in the history

  10. Replace ProbingNeighborhood::compute by ProbingNeighborhood::hexagonS… 

    …tate
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    45d8292 View commit details
    Browse the repository at this point in the history

  11. Fix mistake in PlaneProbingTetrahedronEstimator::compute

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    0a7fc0c View commit details
    Browse the repository at this point in the history

  12. Fix functions that didn't use correct Integer type, add testPlaneProb… 

    …ingTetrahedronEstimator
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    5a5af14 View commit details
    Browse the repository at this point in the history

  13. Forgot to add the CMakeLists

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    b254d0f View commit details
    Browse the repository at this point in the history

  14. Add PlaneProbingParallelepipedEstimator::translateQ

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    2f72854 View commit details
    Browse the repository at this point in the history

  15. Add PlaneProbingParallelepipedEstimator adapter

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    1f7a39b View commit details
    Browse the repository at this point in the history

  16. Also test BigInteger in testPlaneProbingTetrahedronEstimator

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    549176b View commit details
    Browse the repository at this point in the history

  17. Add a test for ParallelepipedEstimator and a specialized class of Tet… 

    …rahedronEstimator
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    673d382 View commit details
    Browse the repository at this point in the history

  18. Put the implementation of NotAbovePredicate in the ih file

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    ecd50ce View commit details
    Browse the repository at this point in the history

  19. Forgot to add the testPlaneProbingParallelepipedEstimator file, remov… 

    …e incorrect file
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    c14f47d View commit details
    Browse the repository at this point in the history

  20. Skeleton of some documentation

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    b9cccb8 View commit details
    Browse the repository at this point in the history

  21. Fix mistake in testPlaneProbingParallelepipedEstimator that used unsi… 

    …gned int instead of int
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    07ec855 View commit details
    Browse the repository at this point in the history

  22. Some cleanup and simplify the parallelepiped adapter

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    3d14625 View commit details
    Browse the repository at this point in the history

  23. Merge Operation and UpdateOperation

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    7e33e4f View commit details
    Browse the repository at this point in the history

  24. Clean up in tests, fix sign error in PlaneProbingNeighborhood::getOpe… 

    …ration
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    12e6cc6 View commit details
    Browse the repository at this point in the history

  25. PlaneProbingTetrahedronEstimator::advance returns (bool, UpdateOperat… 

    …ion)
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    8951196 View commit details
    Browse the repository at this point in the history

  26. Add operation decomposition in PlaneProbingParallelepipedEstimator, a… 

    …lso test PR1 version
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    5bb6ab7 View commit details
    Browse the repository at this point in the history

  27. Add DigitalSurfacePredicate class

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    eeeed1c View commit details
    Browse the repository at this point in the history

  28. Add PlaneProbingDigitalSurfaceLocalEstimator class

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    02cc1db View commit details
    Browse the repository at this point in the history

  29. Fix missing include in DigitalSurface2DSlice

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    3885e7a View commit details
    Browse the repository at this point in the history

  30. Add MaximalSegmentSliceEstimation 

    It is an other way of estimating normals without any parameters, using
slices and maximal segment extraction.
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    bee56f3 View commit details
    Browse the repository at this point in the history

  31. If no pre-estimation is given in the estimator, do one using MaximalS… 

    …egmentSliceEstimation
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    c38eb88 View commit details
    Browse the repository at this point in the history

  32. Add inline qualifiers and clean up

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    d10dea0 View commit details
    Browse the repository at this point in the history

  33. Make the examples and tests C++11 compatible

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    f8d47dd View commit details
    Browse the repository at this point in the history

  34. Some updates (better hashmap, better example)

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    cff67a7 View commit details
    Browse the repository at this point in the history

  35. Add a template file for the documentation of the plane-probing module

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    6272ba7 View commit details
    Browse the repository at this point in the history

  36. fix decompostion and add translateIf function

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    24a7f7f View commit details
    Browse the repository at this point in the history

  37. Remove flatDirections in the quantity returned by MaximalSegmentSlice… 

    …Estimation
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    c2014a5 View commit details
    Browse the repository at this point in the history

  38. Add more constructors to PlaneProbingDigitalSurfaceLocalEstimator

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    469b842 View commit details
    Browse the repository at this point in the history

  39. Fix "isNeighbor" usage to handle normal vectors with zero components … 

    …in PlaneProbingDigitalSurfaceLocalEstimator
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    6a074f8 View commit details
    Browse the repository at this point in the history

  40. We avoid returning a null vector in MaximalSegmentSliceEstimation::eval

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    9ff4d05 View commit details
    Browse the repository at this point in the history

  41. Move PlaneProbingEstimatorCommon to geometry/helpers

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    533112a View commit details
    Browse the repository at this point in the history

  42. Simplify the tests and an example

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    9910f0b View commit details
    Browse the repository at this point in the history

  43. Some documentation

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    d72a050 View commit details
    Browse the repository at this point in the history

  44. Simplify ProbingRay::getRelPt and getAbsPt

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    a4574ea View commit details
    Browse the repository at this point in the history

  45. Do a geometrical decomposition in PlaneProbingParallelepipedEstimator… 

    …::advance
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    baf101e View commit details
    Browse the repository at this point in the history

  46. Remove useless PlaneProbingTetrahedronEstimatorParallelepiped class

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    f914fb5 View commit details
    Browse the repository at this point in the history

  47. Make the probing algorithms more similar, continue the documentation

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    ad32912 View commit details
    Browse the repository at this point in the history

  48. Move the implementation of functions from PlaneProbingEstimatorHelper… 

    … to the ih file
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    c1e1149 View commit details
    Browse the repository at this point in the history

  49. Template for the documentation of estimation using maximal segments a… 

    …nd slices
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    6ee876f View commit details
    Browse the repository at this point in the history

  50. Continue the documentation of the classes

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    73c22ea View commit details
    Browse the repository at this point in the history

  51. Add some images in the user documentation

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    668dbed View commit details
    Browse the repository at this point in the history

  52. Continue the documentation and fix some TODOs

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    f2f1302 View commit details
    Browse the repository at this point in the history

  53. Add ArithmeticalDSSComputerOnSurfels

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    cb68af4 View commit details
    Browse the repository at this point in the history

  54. ArithmeticalDSSComputerOnSurfels: use two surfels for the front and b… 

    …ack directions
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    43deb5b View commit details
    Browse the repository at this point in the history

  55. Use ArithmeticalDSSComputerOnSurfels in MaximalSegmentSliceEstimation

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    84c817d View commit details
    Browse the repository at this point in the history

  56. Move testArithmeticalDSSComputerOnSurfels in geometry/surfaces

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    1e3d043 View commit details
    Browse the repository at this point in the history

  57. Check for separability in the parallelepiped estimator, continue the doc

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    63bb820 View commit details
    Browse the repository at this point in the history

  58. Move ArithmeticalDSSComputerOnSurfels to geometry/surfaces and fix cl… 

    …ang error
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    001b4d0 View commit details
    Browse the repository at this point in the history

  59. ArithmeticalDSSComputerOnSurfels: replace const reference by a pointe… 

    …r, correctly implement some methods
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    48b66bc View commit details
    Browse the repository at this point in the history

  60. Update ChangeLog.md

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    fcf4f98 View commit details
    Browse the repository at this point in the history

  61. Fix some TODOs in ArithmeticalDSSComputerOnSurfels and improve the co… 

    …rresponding test
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    1722848 View commit details
    Browse the repository at this point in the history

  62. Fix include in MaximalSegmentSliceEstimation header

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    dd5f985 View commit details
    Browse the repository at this point in the history

  63. Fix Doxygen warnings

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    ddf0dc3 View commit details
    Browse the repository at this point in the history

  64. User documentation for the maximal segment based estimator

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    1caac71 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2021

  1. Merge branch 'master' into PlaneProbingEstimators

    @JacquesOlivierLachaud
    JacquesOlivierLachaud authored Feb 7, 2021
    Configuration menu
    Copy the full SHA
    025c431 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Fix TODO in PlaneProbingTetrahedronEstimator

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    308d614 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'PlaneProbingEstimators' of github.com:nyorem/DGtal into… 

    … PlaneProbingEstimators
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    9950ab8 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Fix order of initial points in ArithmeticalDSSComputerOnSurfels::init

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    9aca397 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. Merge branch 'master' into PlaneProbingEstimators

    @dcoeurjo
    dcoeurjo authored Feb 15, 2021
    Configuration menu
    Copy the full SHA
    1fa6711 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. Fix some typos in the documentations

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    fe7ecd9 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2021

  1. Merge branch 'master' into PlaneProbingEstimators

    @JacquesOlivierLachaud
    JacquesOlivierLachaud authored Feb 20, 2021
    Configuration menu
    Copy the full SHA
    3e2a24f View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Changes according to reviews

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    646bbe7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'PlaneProbingEstimators' of github.com:nyorem/DGtal into… 

    … PlaneProbingEstimators
    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    c8d818d View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Last changes according to reviews (mostly renaming)

    Jocelyn MEYRON authored and Jocelyn MEYRON committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    6ef56e8 View commit details
    Browse the repository at this point in the history