Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMakeLists #1567

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Update CMakeLists #1567

merged 2 commits into from
Apr 29, 2021

Conversation

JacquesOlivierLachaud
Copy link
Member

PR Description

Fix #1566 by preventing build if WITH_GMP is not set.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo
Copy link
Member

👌 thx

@dcoeurjo dcoeurjo self-requested a review April 29, 2021 09:31
@dcoeurjo dcoeurjo mentioned this pull request Apr 29, 2021
Closed
@JacquesOlivierLachaud
Copy link
Member Author

Looks ok. Self-merge.

@JacquesOlivierLachaud JacquesOlivierLachaud merged commit 569c911 into DGtal-team:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoeurjo dcoeurjo dcoeurjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

checkLatticeBallQuickHull does not compile if GMP not installed
2 participants
@JacquesOlivierLachaud @dcoeurjo